search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.74k stars 702 forks source link

Gen 1 Tooltip mismatch info #3372

Closed Ninjistix closed 2 years ago

Ninjistix commented 2 years ago

Describe the bug the tooltip that you get when you hover over Pokémon in Gen 1 that shows their information is invalid for some Pokémon.

To Reproduce Steps to reproduce the behavior:

  1. Open gen 1 save
  2. Hover over X Pokémon to see their tooltip
  3. See errors

Expected behavior Some Pokémon show the correct tooltip information and some of them are wrong.

Screenshots [Correct Tooltip] image image

[Invalid Tooltip] image image image

Additional context There's several Pokémon that display the correct game origin or catch location, but there's even more that display either a Gen2 or other game location.

Edit: note sure if this applies to other Games/Generations as I haven't rechecked them in awhile

kwsch commented 2 years ago

Since Gen1 does not store met location, the program matches whatever is valid first.

It might not have been where you actually obtained it, but it's where you could have obtained it (in the context of the current data). If there's 100 different encounters that it could be, how would it know which was the actual one you encountered it with since they're all the same result? Hence, PKHeX just chooses whatever is satisfactory first.