search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.74k stars 702 forks source link

UTF-8 encoding é is broken on non-Windows systems, breaking builds #3519

Closed jonbarrow closed 2 years ago

jonbarrow commented 2 years ago

Describe the bug When files containing characters such as é, like MenuOrderOption.cs, are viewed or cloned into non-Windows systems, the character é is wrongly encoded and results in � being used instead. This breaks building unless manually changed

Checked on MacOS and Ubuntu

To Reproduce Clone the repo on a non-Windows system and view PKHeX/PKHeX.Core/Saves/Substructures/Gen8/ValueBlocks/MenuOrderOption.cs in a code editor. Or view the raw file on GitHub in any browser

Expected behavior For the formatting to not be messed up and the correct character shown

Screenshots

kwsch commented 2 years ago

Thanks; lemme know if there's any other problematic files re: encoding, or considerations for compiling on non-windows systems. I don't venture far from my Windows bubble ;)