kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.71k stars 698 forks source link

Gen 4 Nickname too long from Pokémon renamed in different language game #3980

Closed WildEep219 closed 1 year ago

WildEep219 commented 1 year ago

Describe the problem If you have a Pokémon from one language in gen 4 (such as Japanese) and trade it to an English gen 4 game with the same trainer ID, you can rename the Pokémon (unlike other generations, the name doesn't need to match, just the TID). This can result in Japanese Pokémon with English characters in the nickname. Such a Pokémon can have PKHeX flag it for its nickname being too long.

To Reproduce I attached a PKM of an otherwise-legal Japanese Palkia I obtained from the GTS that I changed the name of in English Pearl with a save with a matching TID. See the Additional context section.

Expected behavior This Palkia should be considered legal.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here. 0484 - ReallyLong - D30E2242A1DF.zip

kwsch commented 1 year ago

https://github.com/kwsch/PKHeX/issues/3809

If it is only possible to do this through RNG manipulating or editing OT/TID to match a Pokémon in another language, the preferred handling is to flag these Pokémon.

Randomly getting into the situation that you can somehow name a Pokémon from another save game is very, very unlikely. The vast majority that break the rule will be hacked. Anyone who is RNG manipulating knows what they did and can ignore the flag.