search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.64k stars 684 forks source link

BallUseLegality #4263

Closed bdawg1989 closed 4 months ago

bdawg1989 commented 4 months ago

Can you please make this class accessible instead of internal? I am using it for another project and would rather not have to make a new fork just for this update.

kwsch commented 4 months ago

It's not intended to be used externally by others, because it only surfaces permission bitflags.

Is BallApplicator not relevant to your use case? https://github.com/kwsch/PKHeX/blob/bcb7135940ea2c7ab4cedce1b104c0432a79bdfe/PKHeX.Core/Editing/Applicators/BallApplicator.cs#L10

bdawg1989 commented 4 months ago

It's not intended to be used externally by others, because it only surfaces permission bitflags.

Is BallApplicator not relevant to your use case?

https://github.com/kwsch/PKHeX/blob/bcb7135940ea2c7ab4cedce1b104c0432a79bdfe/PKHeX.Core/Editing/Applicators/BallApplicator.cs#L10

Ugh, you are such a genius I swear.

That worked like a charm, thank you.

I'm working on an Auto Correct feature for showdown sets and this allowed me to also use a fallback method to use the color matched legal ball if a close match wasn't found.

image

Thanks Kurt <3

kwsch commented 4 months ago

There's other applicators to fix stuff, like ribbons. Glad to hear it worked for you.