kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.72k stars 699 forks source link

Use straight apostrophe for Gen3/4 #4275

Closed abcboy101 closed 5 months ago

abcboy101 commented 5 months ago

Follow-up on 326e790:

Colosseum/XD/PBR/Ranch all treat the apostrophe/right single quote as a straight apostrophe (', U+0027) like Gen5, so this PR changes the Gen3/4 character tables to use the straight apostrophe as well. For user-friendly input, the curly apostrophe is remapped to ' in StringConverter3/4.

This primarily affects unnicknamed XD Farfetch'd, which need to use ' instead of to be traded to GBA correctly. A Farfetch'd named FARFETCH’D instead becomes FARFETCH$D, with the Pokémon Dollar symbol in place of the apostrophe. (I have the rest of the Colo/XD GBA/Unicode mappings researched, but not implemented yet.)

Box R&S treats the apostrophe as a CP-1252 curly quote (, 0x92), but this doesn't have any practical effect.