search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.72k stars 699 forks source link

Friend Ball Bug #4282

Closed mxava closed 5 months ago

mxava commented 5 months ago

Hi hi!

When I attempt to modify a pokemon to have been caught with a friend ball, it shows as having been caught by a pokeball when I attempt to save it.

When I load a pokemon to be edited again, it shows as having been caught by a pokeball, which indicates to me the bug is probably not visual.

Steps to reproduce the behavior:

  1. Go to 'Met' menu
  2. Select Friend Ball from the dropdown.
  3. Move pokemon into a box slot
  4. See pokeball is a regular pokeball.
  5. Attempt to load pokemon from box for further editing, and you will find it's a regular pokeball instead of the friend ball which was selected.

Expected behavior would be that the pokemon reflects that it has been caught by a friend ball.

I stumbled across this on a HGSS save file - I haven't checked for other games/gens.

Lusamine commented 5 months ago

I tried this on a Pokémon from HGSS in HGSS and it worked fine. Then, I tried it on a Pokémon from Platinum in HGSS and it reset to Poké Ball. What Pokémon are you specifically trying to edit?

kwsch commented 5 months ago

Working as intended. Be sure you are editing something that originated from HG/SS when trying to set an HG/SS ball.

https://github.com/kwsch/PKHeX/blob/a7421a7cebd598776de91edd8d745a199709d3f2/PKHeX.Core/PKM/Shared/G4PKM.cs#L259-L282