kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.72k stars 699 forks source link

Valid Nicknamed event gift Pokemon in Gen V. #4288

Closed 902PM closed 5 months ago

902PM commented 5 months ago

In the Japanese version, There are event Pokemon has been nicknamed.(Politoed and Kingdra) Politoed has a nickname of ニョロペロ(Nyoropero). Kingdra has a nickname of キングペロ(Kingpero).

https://bulbapedia.bulbagarden.net/wiki/List_of_local_Japanese_event_Pok%C3%A9mon_distributions_(Generation_V)#Yamamoto's_Tournament_Pok%C3%A9mon ↑Details of those Pokemon.

but, These Pokemon are invalid Pokemon in PkHeX. Please handle exceptions for these Pokemon.

2 3

I'm not a native speaker, so please excuse me if my English is difficult to understand.

kwsch commented 5 months ago

Works fine on latest commits. image

https://github.com/kwsch/PKHeX/blame/99a514b0bcb5327da2a9ccdc1cc5210abb1b40aa/PKHeX.Core/Legality/Verifiers/NicknameVerifier.cs#L78-L91

Lusamine commented 5 months ago

In the future, check if the error is still present on the latest commit before you report it. If you can't build the program yourself, you can download the Development Build.