kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.63k stars 682 forks source link

Changing box names in Box Layout editor with ORAS saves is overwriting the wrong boxes and throwing an error #4322

Closed javierhimura closed 1 month ago

javierhimura commented 1 month ago

Describe the bug If you open a ORAS Save File and open the Box Layout Editor and change the name in a box between 2 and 15 the change will be the applied to a wrong box between 3 and 31 (I think the box offset is the double, or double plus 1). Any change in the name of boxes between 16 and 31 gives and System. ArgumentOutOfRangeException error

To Reproduce Steps to reproduce the behavior:

  1. Open a save file from Alpha Sapphire or Omega Ruby
  2. Click on Box Layout Editor
  3. Edit the name of any books except the first one. If the box is between 16 and 31 the program will throw an error.
  4. Click Save.
  5. Open Box Layout Editor again
  6. The name will be changed in an incorrect box.

Expected behavior

Screenshots imagen.

imagen

imagen

Additional context .