kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.71k stars 696 forks source link

When reading/writing an oras save file, under the trainer records section, the number of secret base battles in your base is actually the number of fishing chains #4331

Closed Priestyle closed 3 months ago

Priestyle commented 3 months ago

Describe the bug Under the trainer records section, the number of secret base battles in your base is actually the number of fishing chains

To Reproduce Steps to reproduce the behavior:

  1. Go to the Trainer Info then go to the trainer records section and then scroll down to the number of fishing chains

Expected behavior The 2 trainer records should be flip-flopped.

Screenshots I took a video instead for even better accuracy. Here's the link: https://streamable.com/rqr10a

Additional context There are probably many other records that got mixed. It was mentioned in Discord once too. Here's the link: https://discordapp.com/channels/343093766477053953/367479180398428170/1266536445800222883

kwsch commented 3 months ago

Are you using the latest development build? The most recent commit revised the numbers for these.

Priestyle commented 3 months ago

Oh, I just downloaded to the latest development build and it was fixed there. Thanks a lot!