kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.63k stars 682 forks source link

FR/LG Unown Show Incorrect Origin Seed #4345

Closed AiTeknoparrot closed 3 weeks ago

AiTeknoparrot commented 3 weeks ago

Describe the problem It appears Unown encountered using Sweet Scent have their PIDIV origin seed reported incorrectly in the 20240724 build of PKHeX. I originally wrote this off as a quirk of both mGBA emulation and vblanks, but several Unown samples are exhibiting similar behavior.

To Reproduce In PokeFinder 4.2.1, in Generator tab, input the initial Seed hit and desired encounter slot Unown letter for Method "Wild 1". Input Delay of 265 for Sweet Scent and hit the desired frame for encounter spawn to hit the Unown letter of choice.

Expected behavior I expect the origin seed for this particular sample Unown to be 35E4B82F per PokeFinder 4.2.1 the Searcher tab. PID generated in-game matches the expected origin seed. Instead, PKHeX reports an origin seed of C6D84CB1. Going to the PokeFinder Generator tab, this origin seed has no such PIDIV combination, therefore PKHeX marks it as (X). However, PKHeX is arriving to the wrong origin seed to begin with.

Screenshots

image image

Additional context mGBA is version 0.11. Game was played sped up. No ACE or cheat codes were used.

MrPerson0 commented 3 weeks ago

Have you tried the latest dev build? Think this was fixed back on August 7: https://github.com/kwsch/PKHeX/commit/c9f38940764b2682c3a1a363ad0c669b05651a1d

AiTeknoparrot commented 3 weeks ago

I have no means to compile a dev build at the moment but the issue is strikingly similar. I suspect then it probably is fixed and I will close. Thank you.

MrPerson0 commented 3 weeks ago

If you want to test it out, you can download the dev build here: https://projectpokemon.org/home/files/file/2445-pkhex-development-build/

AiTeknoparrot commented 3 weeks ago

Thank you, this is very helpful. I confirmed that the issue was fixed. image