search

kwsch / SysBot.NET

sys-botbase client for remote control automation of Nintendo Switch consoles.
https://projectpokemon.org/home/files/file/4207-sysbot-automatic-build/
GNU Affero General Public License v3.0
463 stars 270 forks source link

Update Decoder.cs #115

Closed ca1e closed 3 years ago

ca1e commented 3 years ago

getTitleID and getBuildID will crash the decoder without lower hex checked

Koi-3088 commented 3 years ago

Seems like this would be specifically for sys-botbase compatibility for getBuildID as usb-botbase does not reference Decoder at all.

Funnily enough, while usb-botbase retrieves meta.buildID in commands.c, it does not have it implemented as a usable command in main.c. Furthermore, while other usb-botbase responses return ready-to-use byte arrays that do not need Array.Reverse(), this particular command seems to be an exception. Forks would have to implement it something like this when I push a usb-botbase compatibility commit for getBuildID. image