kwsch / SysBot.NET

sys-botbase client for remote control automation of Nintendo Switch consoles.
https://projectpokemon.org/home/files/file/4207-sysbot-automatic-build/
GNU Affero General Public License v3.0
462 stars 270 forks source link

Twitch integration stops working with invalid nickname request #72

Closed BobandyLive closed 4 years ago

BobandyLive commented 4 years ago

I stumbled upon an issue that's been causing major issues with my SysBot on Twitch over the last couple days. If a user requests a Pokemon without a nickname but puts the name of the pokemon in parenthesis, the bot will stop processing commands on Twitch. It will still keep going through random distributions and work on Discord, but it completely breaks the Twitch commands when it happens.

For example, if you go into your Twitch chat and do the following request it will trigger the issue: $trade (Pikachu)

As a temporary solution I've added the following moderation filter on my Twitch account which blocks people from making these types of requests: "$trade (*"

I've instructed my users not to do this obviously, but if someone wants to be malicious and continue to break the bots on Twitch that can be a major headache.

Lusamine commented 4 years ago

Just wondering, do you have brute force on? This is not recommended because it is CPU intensive and can tie up the bot trying to process something that won't work at all.

BobandyLive commented 4 years ago

I do and I thought perhaps that was causing the issue so I tried disabling it and it was still happening even with brute force turned off.

architdate commented 4 years ago

I recommend you always turn off bruteforce, but ill fix this issue internally too