kwsch
commented
4 years ago The Remote wait was initially intended as a way for people to start/hold the bots via a remote trigger (via Discord command, maybe automated or something).
The default logic (using the regular Barrier) waits for all participants to be at the barrier, then releases them. The Remote barrier would only unleash any waiting bots when the logic was called -- maybe through discord integration or whatever.
In observing the program's use over the past few months, we've noticed the following:
- Most hosts don't run distribution / surprise trades; custom trades bring in more audience.
- Most hosts don't synchronize bots, instead preferring them to run as fast as possible.
- Nobody wanted to remotely synchronize bots, as the local all-bot synchronization was sufficient.
- Queue management (auto-locking) and bot pausing works fine as a remote-sync substitute.
I don't think the RemoteBarrier logic is necessary; it's just vestigial code from early days where we weren't sure which features would be useful.
Should be fine to remove it, and the associated toggle settings.
https://github.com/kwsch/SysBot.NET/blob/42994df0a99e856901d5c98f74551abc997ace08/SysBot.Pokemon/BotTrade/PokeTradeBot.cs#L619-L621 https://github.com/kwsch/SysBot.NET/blob/0cb605dcb2c4460f0e96e70f79b1f06c2ca93502/SysBot.Base/Synchronization/BotSyncOption.cs#L14-L18
From SysBot.Base/Synchronization/BotSynchronizer.cs:
An anecdote from Discord suggests the "Remote" parameter can safely be removed, although further investigation is best.
Additional Reading: https://stackoverflow.com/questions/53526755/net-core-2-1-eventwaithandle-not-supported