kwsch / pkNX

Pokémon (Nintendo Switch) ROM Editor & Randomizer

https://projectpokemon.org/home/forums/topic/48647-pknx-nintendo-switch-rom-editor-randomizer/

GNU General Public License v3.0

352 stars 108 forks source link

Generated folder is always SWORD's title ID #110

Closed ewormPL closed 3 years ago

ewormPL commented 3 years ago

For some reason whether I modify Sword or Shield, pkNX always names the folder with the modified files after Sword's Title ID, never Shield's.

sora10pls commented 3 years ago

79 RomFS is identical across both games.

Offset 0x290 of main.npdm contains the Title ID, and pkNX can be updated to grab it from this file rather than hardcode the Title IDs for LGP, LGE, SW, and SH.

CodingKoopa commented 3 years ago

This was fixed for the latest SwSh update with #127. The issue remains for LGPE and other SwSh versions; it may still be better to implement @sora10pls's idea to cover all of them. I hadn't seen that before implementing my PR.