kwsch / pkNX

Pokémon (Nintendo Switch) ROM Editor & Randomizer
https://projectpokemon.org/home/forums/topic/48647-pknx-nintendo-switch-rom-editor-randomizer/
GNU General Public License v3.0
352 stars 108 forks source link

Backpropagation of inheritance #218

Open Salier13 opened 2 years ago

Salier13 commented 2 years ago

In the case of a mon having obtained a pre-evolution later in the game, and by such the pre-evolution coming later in the dex than the mon. The types/ability inheritence system doesn't work as it goes through the dex with a linear process going only from basic to evolution and not the opposite (Example of Magby 240 / Magmar 126).

https://github.com/kwsch/pkNX/blob/fe9e21749fa548f5efbf150867b6373bdd30ca99/pkNX.Randomization/Randomizers/Personal/PersonalRandomizer.cs#L102-L109

This could be fixed by allowing the randomizer to inherit to an already randomized pokemon as i don't believe that there is a pokemon evolving into multiple pokemons and that come after those in the dex.