Use interfaces for personal info to make updating the data easier

kwsch / pkNX

Pokémon (Nintendo Switch) ROM Editor & Randomizer

https://projectpokemon.org/home/forums/topic/48647-pknx-nintendo-switch-rom-editor-randomizer/

GNU General Public License v3.0

343 stars 108 forks source link

Use interfaces for personal info to make updating the data easier #234

Closed duckdoom4 closed 1 year ago

duckdoom4 commented 1 year ago

Added a whole bunch of interfaces for PersonalInfo and added versioning where needed
Added some if checks to make sure the code only runs on supported interface versions
Added IPersonalInfoBin for the older versions that use binary databases
Removed PLA Binary wrapper. It's no longer needed now that the code is based on interface functions.
Changed uses of PersonalInfo to the interface version IPersonalInfo (or more specific interface version)

Would have loved to use default interface implementation, but net461 doesn't support it -Sorry for the large PR 🙂

kwsch commented 1 year ago

Might be worth comparing to the interfaces that were recently extracted in PKHeX. Both of these projects mirror each other somewhat... https://github.com/kwsch/PKHeX/tree/master/PKHeX.Core/PersonalInfo

duckdoom4 commented 1 year ago

Ah yeah, that might be nice. I will compare and update tomorrow.

I wish I had seen it sooner. Would have saved me some hours of work 🤣

duckdoom4 commented 1 year ago

I've updated the code with a merge from pkHeX and some of my edits. I have tried to split the code into bite sized commits, but not all of them will compile individually so not sure how usefull that is.

Unfortunately, that made the PR even larger 🤣