kwsch / pkNX

Pokémon (Nintendo Switch) ROM Editor & Randomizer
https://projectpokemon.org/home/forums/topic/48647-pknx-nintendo-switch-rom-editor-randomizer/
GNU General Public License v3.0
352 stars 108 forks source link

PLA randomizer is non-functional #318

Open RevanXVIV opened 1 year ago

RevanXVIV commented 1 year ago

Ok so I was making some pretty good progress on my randomizer but then the game started freezing when I tried to enter the hidden cove in the beach area, and at the start of Coronet Highlands, I tried to catch a voltorb and the game froze again.

Is this a bug from the randomizer or the game itself? Are there some pokemon that just shouldn't show up in the randomizer because they cause it to freeze? I'm just trying to figure out what's going on here because I REALLY don't want to have to start a new file AGAIN.

duckdoom4 commented 1 year ago

That would be a bug caused by changes you've made to the files. Possibly a 'bug' (side effect) in the randomizer. As I mentioned a couple of times now, the randomizer is not fit for use. And I have no personal interest in fixing/improving it

RevanXVIV commented 1 year ago

So then why even have legends arceus support? If nobody plans on fixing it, and it's not fit for use, why not just remove it from the tool and let someone else make their own PLA randomizer tool?

kwsch commented 1 year ago

So then why even have legends arceus support? If nobody plans on fixing it, and it's not fit for use, why not just remove it from the tool and let someone else make their own PLA randomizer tool?

If it's so simple, why don't you write your own randomizer tool? PLA has been out for nearly a year; surely someone else would have made one by now...?

Programs are open source, community built, and do not financially compensate the developers for their time. All developers donate their time and expertise to make tools and improve them based on self/community feedback, if they want to spend time on the tool in question. It is unreasonable to expect that every free tool is feature-rich and iron-clad tested, especially if it is for niche modifications in a game that doesn't really need much editing. PLA is an open world demo game, and there are many other (more interesting) things that a developer may want to spend their time on.

If you have issues with a tool, it is proper etiquette to document what is going wrong and what you changed, to assist the developer in adjusting the program's behavior. It is unhelpful to post issue after issue saying "x doesn't work as I expected" then expect the developer to read your mind and spend an unspecified amount of time finding and resolving the issue. Developers do not know every minor detail of how the game works.

You never need to start a new save file; individual layeredfs mods can be added/removed at any time and the original save data is still retained. If one of your modifications is having issue, it is best practice to isolate what file is causing the issue.

RevanXVIV commented 1 year ago

I meant no disrespect, I was just genuinely curious if support isn't intended for the PLA Randomizer and it doesn't work, why have it added? Legit a curious question, no disrespect intended and I apologized if I made you feel disrespected.

I also had no idea PLA was barely a year old as after SwSH I just kind of stopped following Gamefreak entirely. My friend got the game for me this X-Mas. I've seen how long rando development takes, I remember when ALttP was the only good rando out there, it takes years, which I thought Arceus was at least 2 years old, my bad, to actually make a functioning randomizer.

I guess my final question is: Will PLA Rando eventually get worked on again or is this it's final state?

duckdoom4 commented 1 year ago

The PLA randomizer is 'added' mostly due to copy pasting the code from the SWSH version of pkNX.

I personally have no interest in fixing up the code, but I left it in for any future developer who would be interested in fixing it. The other parts of the PLA randomizer have been added a long time ago (before I joined), probably with a somewhat similar mindset, but seems more functional.

Is it annoying for certain end users, who expect ui element that appear in the tool to function? Yes, I suppose. Do I want to spend the extra hours on fixing something I don't intend to use? No, I'd rather spend the little time I have on something I would personally use in my game.

As kwsch mentioned, we are all people who spend the little time we have after work hours on something that interests us. Even taking the time to answer these questions and help out others. We don't get paid to do it, there is no company behind this. We get literally one or two additional people who work on it for some time, then decide to move on. Currently there seem to be about 3 people who actively contribute. (Not talking about others who have contributed in the past but are no longer active)

The only reason this tool exists, is because we decided to share our privately made tools with the community and the community then helped improve the private tools with their own features.

So TLDR; Will someone fix it? Maybe

When will it be fixed? If a developer has a personal interest in using and fixing up the code for the randomizer feature. (Which could be tomorrow, or never)

Why is it in there? Because legacy code and other development reasons

RevanXVIV commented 1 year ago

Ok thanks, and again I'm sorry for sounding like an asshole, I'm genuinely interested in this but have no coding experience, at least not for something like this project. I guess I'll just do what I did with the OoT randomizer, check back every few months and see if anything has improved. Fingers crossed.

RevanXVIV commented 3 days ago

Is the randomizer still non functional for PLA? Just curious.