Fixed compatible TRs reading incorrectly.

[TalonSabre]

TR compatibility for each pokemon had been saving to the same list as TM compatibility, and for some reason it was not working as intended. Seemed like an issue with the way the data merged, so I had TRs read and write to an entirely separate variable. After finishing, and seeing that it built and ran, I tested the impacted features, and confirmed it is working.

[TalonSabre]

If I do anything incorrectly or backwards on GitHub, sorry. This is the first time I have really submitted anything to GitHub for use. This was also my first time using C#, so if there is a better way to write any of my code, I am open to learning. This issue annoyed me enough that I taught myself the basics of C#: SwSh TR wrong offsets. I will probably attempt to fix the issue with evolutions next for the same reason. Everyone who contributed to pkNX, thanks for the awesome work up to this point. Have a nice day!

[TalonSabre]

(besides the small comments)

Realizing I type a lot, I put the important bits in bullet points. If you have the time, you could read/skim over the rest.

• For my future reference, would it be better to have longer/more specific comments or no comments for projects on this platform?

I remember being told that keeping documentation is a good idea in general, and adding comments is one way to do that. My assumption is if I don't write comments, I would put the info somewhere like a commit description.

That said, some of the comments are probably redundant anyways, and I only put them in for consistency. For example, where the program iterates through TMs, it has "// TMs" next to it, so I added "// TRs" next to code I added. I guess I probably shouldn't bother with comments unless I know a way to describe the code when isn't self-explanatory?

I'm asking because, even though I don't know how much experience you have coding, you probably know what you're talking about. I'm relatively young, and I'm trying to learn the proper way to do things so that I can find work as a programmer. Part of the issue is that I've never had a teacher/professor say they use comments that much, and I've never been required to add any. As a result:

• I tend not to comment, especially since it's difficult for me to keep things concise while being descriptive. That said, I did try to explain some logic with comments.
• Consider this the last thing I deliberately bother you specifically with. Thanks again, I genuinely appreciate you taking the time!

[duckdoom4]

(When I mentioned 'small comments', I was referring to my own small issues I pointed out about your commit :p)

I guess I probably shouldn't bother with comments unless I know a way to describe the code when isn't self-explanatory?

That's how I usually comment code. I try to think like this:

• Don't leave pointless comments, instead use descriptive variable/function naming. (Write code that explains itself, as they say)
  • If I come back to this code in half a year, would I still understand it without comments?
• Maybe I would understand, but would the average programmer?
• If I work in a large project, should I tell why I coded something the way I did? Or maybe refer to some other logic so the next person who comes across this code knows where to look.
• Documentation on a function can be useful, as that will show up in the IDE when someone wants to use the function. (Nowadays, you can use GitHub copilot for this)

I think it's great you're asking for feedback, don't be afraid to ask. That's how we all become better programmers. I'm also self-taught, but with years of experience I'm now working for large companies in the gaming industry, so it's totally possible!

Lastly I want to say, it's generally a good idea to copy the styles and behaviours used in a particular project (like you did now, so great work!). But don't be afraid to change something if you think it's worth changing. For example the //TMs comment someone else left. Seems kinda useless, so why is it there? Can you add a variable name to make it more clear? Or is it already clear enough without the added comment?

(If you want to make a large change, then I would advise making an issue or discussion thread so you can point out why and other collaborators can point out their ideas/concern's)

[TalonSabre]

It has been a couple days since, but I am just now seeing this. I cannot thank you enough for all the feedback. Your first three bullets make a lot of sense. The first one is something that I try to keep in mind at all times. The next two are things that I understand, but don't think about as much. I never thought about the fourth point before, so that is something I will keep in mind as well.

(When I mentioned 'small comments', I was referring to my own small issues I pointed out about your commit :p)

It is still something I struggle with, so I went ahead and asked, but I didn't think that was what you meant xd

[duckdoom4]

Let get this merged 🎉