kwsch / pkNX

Pokémon (Nintendo Switch) ROM Editor & Randomizer
https://projectpokemon.org/home/forums/topic/48647-pknx-nintendo-switch-rom-editor-randomizer/
GNU General Public License v3.0
338 stars 106 forks source link

AreaSettings.bin flags not being saved in PLA #357

Open drvictorvs opened 5 months ago

drvictorvs commented 5 months ago

In the Fields editor on PLA, the editor only saves the subtables under AreaSettingsTable, as can be seen below:

pkNX.Structures.FlatBuffers.Arceus\Arceus\Field\Resident\Editing\ResidentArea.cs

public void SaveInfo()
    {
        TryWrite(Settings.Encounters, Encounters);
        TryWrite(Settings.Locations, Locations);
        TryWrite(Settings.Spawners, Spawners);
        TryWrite(Settings.WormholeSpawners, Wormholes);
        TryWrite(Settings.LandmarkItemSpawns, LandItems);
        TryWrite(Settings.LandmarkItems, LandMarks);
        TryWrite(Settings.UnownSpawners, Unown);
        TryWrite(Settings.Mkrg, Mikaruge);
        TryWrite(Settings.SearchItem, SearchItem);
    }

Meaning all the other fields under pkNX.Structures.FlatBuffers.Arceus\Schemas\Field\Resident\AreaSettingsTable.fbs are not being saved.

The method for writing the remaining fields under the AreaSettings class is not implemented for the function Write. Is there some technical limitation for that?

Best regards.

duckdoom5 commented 5 months ago

Not that I know of. I suppose someone just forgot to implement them