General Sword and Shield Bugs/Potential Additions

kwsch / pkNX

Pokémon (Nintendo Switch) ROM Editor & Randomizer

https://projectpokemon.org/home/forums/topic/48647-pknx-nintendo-switch-rom-editor-randomizer/

GNU General Public License v3.0

352 stars 108 forks source link

General Sword and Shield Bugs/Potential Additions #40

Closed sora10pls closed 4 years ago

sora10pls commented 4 years ago

Edit (12.16.2019): Several bugs have been fixed and have therefore been removed from the original post.

A few of the bugs I've encountered with pkNX recently. This issue serves as a compilation of what needs to be fixed.

Editing Gifts can crash the game
- Editing multiple values at a time can lead to this crash
- Species, Ball, and CanGigantamax are what I've tested this with
- Filesize can change drastically (related?)

kwsch commented 4 years ago

File size change is due to incorrect field sizes (byte vs int) in flatbuffer definitions

SnakeDeath commented 4 years ago

not sure if these related but it happens when changing the trade pokemon , looks like the .bin file is not generated

eliKnaffo commented 4 years ago

my PkNX saves both games as the first version of Sword and i cant play edited games anymore no idea how to fix this

sora10pls commented 4 years ago

@eliKnaffo Dump the 1.1.0 patch and edit that, support for it and Galarian Slowpoke was added recently.

As for which version is saved, pkNX currently defaults to Sword (no code to differentiate the two as of now, unlike LGPE). If you’re playing Shield, just rename the outputted Title ID folder to match Shield’s instead of Sword’s.