search

kwuunnn / pe

0 stars 0 forks source link

Not allowed to add phone number of more than 10 digits #3

Open kwuunnn opened 5 months ago

kwuunnn commented 5 months ago

image.png

International Phone numbers can be maximum 15 digits, however the app prevents me from adding phone numbers of more than 10 digits

soc-se-bot commented 5 months ago

Team's Response

It is reasonable for us, as developers, to have the understanding that all students, despite the fact that they could be international or exchange student, would hold a Singapore number for the purpose of contacting them locally in Singapore. For instance, if a staff from NUS wants to contact them, it would not be possible to reach them without a Singapore number if these students were to provide their original number. Therefore, our team decision was to cater for Singapore number of 8 digits, with 2 more digits for country code (65) , therefore the allowance of 8-10 digits in the PHONE_NUMBER field.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Restricting the 8-digit phone number

Step:

  1. Enter " add id/E7654321 n/Betsy Crowe t/TA e/betsycrowe@example.com p/ 111133334444555" in the command panel.

Expected: Able to save the user information.

Actual: Error message "Phone numbers should only contain numbers, it should be between 3-10 digits long" is thrown to us instead.

Reason: Some phone number consist of more than 8 digits, especially in international contexts. Restricting phone numbers to only 8 digits could prevent users from inputting their complete phone numbers, leading to communication failures or inconvenience

Screenshot:

image.png

[original: nus-cs2103-AY2324S2/pe-interim#2227] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is reasonable for us, as developers, to have the understanding that all students, despite the fact that they could be international or exchange student, would hold a Singapore number for the purpose of contacting them locally in Singapore. For instance, if a staff from NUS wants to contact them, it would not be possible to reach them without a Singapore number if these students were to provide their original number. Therefore, our team decision was to cater for Singapore number of 8 digits, with 2 more digits for country code (65) , therefore the allowance of 8-10 digits in the PHONE_NUMBER field.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** > It is reasonable for us, as developers, to have the understanding that all students, despite the fact that they could be international or exchange student, would hold a Singapore number for the purpose of contacting them locally in Singapore. Well the truth is most TAs would use telegram handles, so you are making a bold assumption that exchange students get a local number. Some just stick to telegram, and the phone number associated with their telegram is an international number. Since you do not keep track of telegram handles, you would have to keep track of their international phone number in order to attain their telegram.