issues
search
kxov
/
api-server
0
stars
0
forks
source link
Review 1
#1
Open
tshemsedinov
opened
2 years ago
tshemsedinov
commented
2 years ago
Consider use Map here
https://github.com/kxov/api-server/blob/f96bd94997f2129a4cad0d3384ec6b09c765ab59/server.js#L9
Magic number
https://github.com/kxov/api-server/blob/f96bd94997f2129a4cad0d3384ec6b09c765ab59/server.js#L44
Looks strange to put cache with req, res and parsed cookies
https://github.com/kxov/api-server/blob/f96bd94997f2129a4cad0d3384ec6b09c765ab59/app/context.js#L3
Try to use template strings here
https://github.com/kxov/api-server/blob/f96bd94997f2129a4cad0d3384ec6b09c765ab59/app/logger.js#L3
Need space here, maybe you can use eslint before commit
https://github.com/kxov/api-server/blob/f96bd94997f2129a4cad0d3384ec6b09c765ab59/app/response.js#L3
Move receiveArgs to utilities, it is a strange place to hold it in
person
-
https://github.com/kxov/api-server/blob/f96bd94997f2129a4cad0d3384ec6b09c765ab59/app/routes/person.js#L7-L14
Wrong place to write cache
https://github.com/kxov/api-server/blob/f96bd94997f2129a4cad0d3384ec6b09c765ab59/app/routes/person.js#L24
Better use docker instead of nodemon or handle errors in node to prevent exits
kxov
commented
2 years ago
thanks for your review, i added some fixes
person
- https://github.com/kxov/api-server/blob/f96bd94997f2129a4cad0d3384ec6b09c765ab59/app/routes/person.js#L7-L14