search

kxproject / kx-audio-driver

kX driver source code (for Windows and Mac)
Other
143 stars 64 forks source link

bug in calculating beta coeficient #24

Open robszy opened 4 years ago

robszy commented 4 years ago

Hi

While looking at code i found that calculating beta is not right because all variables should be in sqrt.

Now it is like:

https://github.com/kxproject/kx-audio-driver/blob/19d1e856533e475b702121c42fd9463855808947/kxfx_pack/EQ_Lowshelf.cpp#L78

Shouldbe

beta = sqrt((TMP*TMP+1)/(eqband/10.)-((TMP-1)*(TMP-1)));

Also Highshelf is also affected

Reference: https://www.musicdsp.org/en/latest/Filters/198-rbj-audio-eq-cookbook.html#

ITzTravelInTime commented 2 years ago

Will integrate in my fork of the driver thank you.

(https://github.com/ITzTravelInTime/kx-audio-driver/tree/PPC_Experimental you find it here, it's currently broken for windows compiling since it's a fork focusing on support for powerpc and intel macs)