search

kxr / o-must-gather

oc like tool that works with must-gather rather than OpenShift API
GNU General Public License v3.0
161 stars 73 forks source link

Ossm configs #63

Open saurabhsadhale opened 3 years ago

saurabhsadhale commented 3 years ago

@kxr Added ServiceMeshControlPlane, ServiceMeshMemberRoll, and Istio Configuration resources code.

saurabhsadhale commented 3 years ago

@kxr this test checks for a autocomplete function. When the checks are running the result would get populated with servi* which includes service, servicemeshcontrolplane, servicemeshmemberroll & serviceentry which is why it is getting an error.

Can we change the test or make it more robust ?

kxr commented 3 years ago

@saurabhsadhale yes you are right. If you have the time feel free to update the tests. Otherwise I will do it when I am free.