kxr / o-must-gather

oc like tool that works with must-gather rather than OpenShift API
GNU General Public License v3.0
161 stars 73 forks source link

Allow 'omg use' to inflate a must gather file. #67

Closed qlixed closed 3 years ago

qlixed commented 3 years ago

This PR enable the 'omg use' subcommand to be used directly with a valid must-gather compressed file. What is a valid must-gather file?:

kxr commented 3 years ago

@qlixed Thank you for the contribution. Honestly, I am not fully convinced if omg should take care of inflating the archive :) I am currently re-structuring the code for v2. I will review and merge this in the newer implementation.

qlixed commented 3 years ago

I don't understand why you don't want to add this quite simple functionality: It introduces a minimal amount of code, do not disturb the "classic" flow at all and add something that will be useful for a lot of users as all the must-gathers are usually send as a compressed file for a review. Anyone that have some automation (or do it manually) for process the must-gathers that decompress the file will not be affected for this. Also I think that the functionality was added in a simple way to the current code workflow of the 'use' subcommand allowing an easy port to the new v2 release, but in case that you need some help to integrate it to the v2 I'm available to help you out if you want.

kxr commented 3 years ago

It introduces a minimal amount of code, do not disturb the "classic" flow at all and add something that will be useful for a lot of users as all the must-gathers are usually send as a compressed file for a review. Anyone that have some automation (or do it manually) for process the must-gathers that decompress the file will not be affected for this.

Yeah you are right. What you said makes sense.