Bad spacing in startup message

[GoogleCodeExporter]

What steps will reproduce the problem?
On boot

Running menu commands(hangup means you have a problematic config)...

What is the expected output? What do you see instead?

There should be a space before ( and the text is much not really good English 
and is untidy.

I suggest:

Running commands in menu file...

It is clearer to the user that the problem is with the menu file if it hangs 
and is much nicer when it flashes up on the screen. It would be even more 
helpful if you actually printed the name of the menu file that hangs! e.g.

Running commands in file /menu.lst

What version of the product are you using? On what operating system?
0.4.5c

Please provide any additional information below.

Original issue reported on code.google.com by Steve6375 on 18 Jun 2013 at 8:41

[GoogleCodeExporter]

Try the attached source file please.

Original comment by tinyb...@gmail.com on 20 Jun 2013 at 10:37

• Changed state: Started

[GoogleCodeExporter]

Thanks, but typo
printf ("Precessing menu file %s ...\n", configfile);
should be
printf ("Processing menu file %s ...\n", configfile);

also"Processing the %spreset-menu ...\n" needs a space
"Processing the %s preset-menu ...\n"

Also would be nice if this message could be disabled using a command (e.g. 
debug off) so that any sub-menus that are loaded by configfile do not show this 
message to the end user.

If the menu file has spaces in the filename, is it displayed as  my/ menu.cfg  
or my menu.cfg?

Original comment by Steve6375 on 20 Jun 2013 at 10:47

[GoogleCodeExporter]

OK. Corrected. Try this one please.

>>> If the menu file has spaces in the filename, is it displayed as  my/ 
menu.cfg  or my menu.cfg?

If a menu filename contains spaces, it might not work. I think at least you 
should quote each space with a back-slash. And it will be displayed with a 
back-slash preceding each space, surely.

>>> Also would be nice if this message could be disabled using a command (e.g. 
debug off) so that any sub-menus that are loaded by configfile do not show this 
message to the end user.

There is no "documented" way to disable this message. Too many users 
encountered hangups and fed back to the developers. They complained grub4dos is 
too buggy and causing too many hangups. But in fact, the hangups are due to the 
wrong or problematic setup in the preset menu or the menu file on disk.

The same problem could be encountered when a menu file is loaded by the 
configfile command. So this message should be displayed before each menu file 
is processed.

Original comment by tinyb...@gmail.com on 21 Jun 2013 at 4:13

[GoogleCodeExporter]

Original comment by tinyb...@gmail.com on 21 Jun 2013 at 4:14

[GoogleCodeExporter]

Thanks. That is better! :-)
Don't worry about disabling the message, I can patch grldr anyway using 
grub4dos cat --replace to get rid of it.

Original comment by Steve6375 on 21 Jun 2013 at 10:11

[GoogleCodeExporter]

I can't seem to compile the stage2.c version.
If I checkout the 21-05-2013 version (which compiles OK under MinGW) and 
replace stage2.c with the new one, I get this error:

stage2.c: In function 'cmain':
stage2.c:2426:3: error: 'configfile' undeclared (first use in this function)
stage2.c:2426:3: note: each undeclared identifier is reported only once for 
each function it appears in
make[2]: *** [pre_stage2_exec-stage2.o] Error 1
make[2]: Leaving directory `/home/Administrator/g4b21052013/stage2'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/Administrator/g4b21052013'
make: *** [all] Error 2

Original comment by Steve6375 on 21 Jun 2013 at 10:49

[GoogleCodeExporter]

stage2.c source code should be config_file not configfile
        printf ("\rProcessing menu file %s ...\n", config_file);

Also - you have now added some lines which print the grub4dos version
The line is too long for the screen and saved_dir is not printed:

GRUB4DOS 0.4.5c 2013-06-21, saved_drive=0x80, saved_partition=0xFFFF, saved_dir=

This prints twice - can it be removed please?

#ifdef GRUB4DOS_VERSION
        printf ("\rGRUB4DOS " GRUB4DOS_VERSION
        ", saved_drive=0x%X, saved_partition=0x%X, saved_dir=%s\n",
                (unsigned long)saved_drive,
                (unsigned long)saved_partition,
        saved_dir);
#endif

Original comment by Steve6375 on 21 Jun 2013 at 11:09

[GoogleCodeExporter]

Problems fixed. Try once more.

Users might encounter hangup at the preset menu or at an on-disk menu file. The 
message of grub4dos version is needed and helpful. They would know whether or 
not the correct version of grub4dos gained control. And old and buggy version 
could unexpectedly gain control.

This message could print many times, not only twice. Each time the menu is to 
process, the message will print.

As explained previously, these messages should not be disabled.

If you do want to disable it, you may comment it out and build your own version.

Original comment by tinyb...@gmail.com on 22 Jun 2013 at 7:23

[GoogleCodeExporter]

Thanks! :-)

Original comment by Steve6375 on 22 Jun 2013 at 7:34

[GoogleCodeExporter]

Any chance of you looking at Issues #129 and #139 and #141?

Original comment by Steve6375 on 22 Jun 2013 at 7:37

[GoogleCodeExporter]

Code merged. Attachment deleted.

Original comment by tinyb...@gmail.com on 25 Jun 2013 at 12:21

• Changed state: Fixed