search

kyagi / shell-pop-el

shell-pop.el helps you to use shell easily on Emacs. Only one key action to work.
213 stars 21 forks source link

Fix bugs about hook #45

Closed xlighting closed 8 years ago

syohex commented 8 years ago

What about bug ? Could you explain it to us ?

xlighting commented 8 years ago

See the file changed

xlighting commented 8 years ago

my config

 (add-hook 'shell-pop-in-hook (lambda () (setq-local helm-split-window-default-side 'right)))

dosen't work , and then I found something wrong in shell-pop.el

syohex commented 8 years ago

Oh, there is typo.

However why did you change point where hooks are called ?

xlighting commented 8 years ago

Oh,................. because my config

(add-hook 'shell-pop-in-hook (lambda () (setq-local helm-split-window-default-side 'right)))

doesn't work as expected

syohex commented 8 years ago

Oh, there is typo.

Sorry this means shell-pop-up-hook -> shell-pop-in-hook in original code.

xlighting commented 8 years ago

Ok, Can you add a shell-pop-after-in-hook (may be other name)

syohex commented 8 years ago

Can you add a shell-pop-after-in-hook (may be other name)

Yes, will do. Please wait.

xlighting commented 8 years ago

Sorry, I didn't read the README carefully

Thanks