Refactor third party - Githubissues

kyamagu / faiss-wheels

Unofficial faiss wheel builder

MIT License

298 stars 38 forks source link

Refactor third party #94

Closed kyamagu closed 10 months ago

kyamagu commented 10 months ago

Changes:

Switch from static linking to bundling Homebrew libomp on macOS
Update default CUDA version
Enable torch tests

Fix #92

kyamagu commented 10 months ago

Interestingly, adding PyTorch tests results in a deadlock in both Linux and macOS. Apparently, OpenMP is doing something wrong, as failing tests seem to import from tests/common_faiss_tests.py, which explicitly calls fails.omp_set_num_threads(4).

kyamagu commented 10 months ago

Importing faiss/tests/torch_test_contrib.py (which imports contrib/torch_utils.py) modifies the faiss APIs, which results in numerous testing errors where some cause hangs. It is better NOT to import contrib/torch_utils.py in any test except for this torch test. Besides that, this test might be a good place to debug the long-standing libomp issue (#73).