search

kyamagu / mexopencv

Collection and a development kit of matlab mex functions for OpenCV library
http://kyamagu.github.io/mexopencv
Other
659 stars 318 forks source link

Typo in Windows-Matlab installation instructions (?) #439

Open jonmatthis opened 5 years ago

jonmatthis commented 5 years ago

In the CMake instructions for installing for Windows/Matlab, you say the build location should be "C:\dev\build\install" but the attached images suggest that you actually set the build location to be "C:\dev\opencv\build\install"

I think that is a typo? I could also be missing something, as this world is all new to me.

In any case - Thank you very much for all of your work on this code and documentation!!

mexopencv

amroamroamro commented 5 years ago

Yes if you followed the instructions in the wiki, the correct location is C:\dev\build\install.

Basically you should have the following directory structure:

pic

The images were taken a while ago, and were never updated to match the current guide. I kept them for illustration purposes :)

jonmatthis commented 5 years ago

Thank you!

By the way, while I am noting minor issues -

The make.m step fails when using the VisualStudio 2017 compiler because of the '-o' flags in the code. After a fair bit of painful googling, I found that replacing all instances of '-o' with '-output' fixes the problem (and throws the warning that the '-output' flag was ignored, so I probably could have just deleted the '-o's'?)