search

kyamagu / psd2svg

PSD to SVG converter.
MIT License
52 stars 17 forks source link

enhance PSD shape layer translation (using SVG shape object) #10

Closed ichiro-arai closed 6 years ago

ichiro-arai commented 7 years ago

I think the following shape layer handling is not executed, because the previous elif clause is executed. (The reason is the majority of shapes has (width, height) > (0, 0))

https://github.com/kyamagu/psd2svg/blob/75c12767fb46c278b575b9dce7b8473a7e548da2/src/psd2svg/converter/core.py#L148

I think if the handling is enhanced, PSD->SVG translation will become better.

(But only reordering the clauses didn't work...!)

kyamagu commented 7 years ago

@ichiro-arai This part should be definitely refactored. The code is from when there was not ShapeLayer class.