Closed HinTak closed 3 months ago
@kyamagu just FYI, the latest bunch of additions to the m127 pull are misc things I found while porting the official SDL2 skia example in google's repo (before they decided it is not particularly special and removed it) in c to python, and the additions basically allow newly written python code to look more like current upstream m1xx skia c API, instead of being stuck in looking like m87. (And the m87-like ones still works - and am just adding redirections, or direct calls to new, where old api was emulated with new).
@kyamagu it looks like CI is failing because it can't get to the github centos host. I an assuming it is either a transient problem (e.g. Microsoft Windows is broken around the world at the moment) or a permanent one I.e. we need to switch to a newer Linux host. Will re-run the CI again later, and look at this again if it doesn't work after re-try. Don't worry.
Centos 7 was EOL on 1st July 2024. Part of manylinux we used. Updating and hope it should be okay now.
The m127 part is quite mundane - GrVkExtensionFlags were gone (withdrawn from public headers).
I have include the doc fix (#249) for apple shader compilation errors. Also while working on that, I found that it is good that old python code using m87-like API continues to work mostly, it is a bit confusing if one is looking at current m12x c code for reference (like trying to rewrite the sdl2 c example in python) , but having to go backward. So it would be nice to have newly written python code mimicking current c code API wise.
To that end, I found that while between m87 and m116,
SkSurfaceProps(inittype)
was removed, a simpler constructorSkSurfaceProps()
was added to replace it - when you just want "any" and don't care - and we simply commented out the removed one only. There are a few things I'd like to add, so that the python version of the sdl example mimic the c sdl example better. etc. So a few more things to add to this. This should build fine.