kyber-6 / mythicmobs-mod

Discover a world of mythical creatures in Minecraft
https://www.curseforge.com/minecraft/mc-mods/mythic-mobs
GNU Lesser General Public License v3.0
6 stars 4 forks source link

[SUGGESTION] Allow automata to be made from bronze from any mod that is tagged properly, as well as repaired with such #3

Open Sunconure11 opened 1 year ago

Sunconure11 commented 1 year ago

Describe your suggestion

Several mods add bronze on their own. It'd be best to allow some compat with such.

kyber-6 commented 1 year ago

Can you point me to some mods which add such compatibility so I can see how they do it?

Sunconure11 commented 1 year ago

https://www.curseforge.com/minecraft/mc-mods/mythicmetals

whatamaniac commented 12 months ago

Or You can also try Brass ingots>Brass Blocks>then construct the golem like vanilla... From Create Mod as it matches the color and a lil bit of Steampunk theme... https://create.fandom.com/wiki/Brass_Ingot

Sunconure11 commented 12 months ago

I think the dev should allow anything tagged/oredict'd as brass to repair, as not everyone has the same mod sets.

milkev commented 11 months ago

To provide compatability with other mods bronze ingots; First you get the c tag in a class: image Then you can check if an item is in the tag like this: image

you would also have to add your bronze ingot to c/items/bronze_ingots.json as well Heres the fabric wiki regarding tags

kyber-6 commented 8 months ago

@milkev

Thank you for this, I am working on an update now to implement everything with tags.

I have also defined TagKey<Block> BRONZE_BLOCKS for creating the Automatons.

Can you help me out for making it so their pattern also checks for tag of BRONZE_BLOCKS instead of the BRONZE_BLOCK I registered in my mod?

this.automatonPattern = BlockPatternBuilder.start().aisle("~^~", "###", "~#~")
                    .where('^', CachedBlockPosition.matchesBlockState(IS_GOLEM_HEAD_PREDICATE))
                    .where('#', CachedBlockPosition.matchesBlockState(BlockStatePredicate.forBlock(BlockRegistry.BRONZE_BLOCK)))
                    .where('~', pos -> pos.getBlockState().isAir()).build();