search

kybishop / ember-popper

Popper.js for Ember
MIT License
39 stars 35 forks source link

Update ember-ref-modifier to 1.0 #114

Closed jrjohnson closed 4 years ago

jrjohnson commented 4 years ago

The breaking change in this version was a parameter re-ordering that is already fixed here and here .

Bumping to the major version helps avoid dependency lint errors in apps.

simonihmig commented 4 years ago

@jrjohnson thanks for working on this!

Some tests in CI are failing though. Not sure if really related to your changes. Did the tests pass for you locally?

jrjohnson commented 4 years ago

No, they fail for me locally, but the same tests seem to be failing on master as well. So I didn't know how deeply I should dig into the failures.

simonihmig commented 4 years ago

Replaced by #117