Popper v2 support - Githubissues

kybishop / ember-popper

Popper.js for Ember

MIT License

39 stars 35 forks source link

Popper v2 support #150

Open pzubar opened 2 years ago

pzubar commented 2 years ago

This PR addresses the following issue.

It updates the addon's code to support popper v2 instead of popper.js. The migration is made according to the official migration guide.

The migration is the breaking change made in order to support the latest Poper's API. The components' API is changed accordingly.

Some of the changes that are not covered in a migration guide:

Popper's scheduleUpdate() is now update() (and returns a promise). That means we can use it directly without wrapping the update with the "ember-raf-scheduler".

tylerturdenpants commented 2 years ago

Ok. Nice. I'll look this over and if all is good we can have a breaking change. Thanks for this work.