search

kyechou / leagueoflegends

League of Legends install and launch wrapper for Linux
https://www.leagueoflegends.com
GNU General Public License v3.0
288 stars 22 forks source link

Suggestion: fix/add these desktop shortcuts to give the game/launchers proper icons #45

Closed coreybruce closed 2 years ago

coreybruce commented 2 years ago

Hi there I just wanted to help and make a suggestion to make the package look a little bit more polished.

I have made a fix to the desktop shortcut so the LOL client will not only show the icon on the shortcut bu will give the LOL client the proper icon instead of the generic missing icon one.

I have made the changes to the league of legend desktop shortcut so the game gets the correct icon on the launcher by adding StartupWMClass=leagueclientux.exe to the shortcut. I also added a desktop shortcut for the riot client so it will also have it's proper icon but the shortcut itself is hidden. I just had the riotclient icon in my .local/share/icons/ folder to test but obviously this would go in /usr/share/icons/hicolor/256x256/apps/ like the leagueoflegends icon which is also on my forked repo.

I also noticed that export ICON="/usr/share/icons/hicolor/256x256/apps/leagueoflegends.png" on the leagueoflegends script does not work, even tho the address is correct and the icon exists zenity still will come up with generic missing icon which doesn't look right.

All of my changes are in my forked repo so feel free to merge. :)

https://github.com/coreybruce/leagueoflegends

kyechou commented 2 years ago

Thanks for the suggestion! I've updated the script.

As for the zenity problem, that's just how it is. There's no way to change the icon shown in the dialog without modifying zenity code. (Reference)

coreybruce commented 2 years ago

Always glad to help out, it's thanks to you I can have a easy way to install League of Legends without issues! 😁

Ahh damn I see so there is no option to add a desktop icon for your own zenity code?

kyechou commented 2 years ago

You're welcome! That's right. There's no option for that as far as I know. There's patch though (https://askubuntu.com/a/570945), but I don't think it's worth the while..