kyechou / leagueoflegends

League of Legends install and launch wrapper for Linux
https://www.leagueoflegends.com
GNU General Public License v3.0
290 stars 22 forks source link

Segfault when running leagueoflegends start #96

Closed brongan closed 1 year ago

brongan commented 1 year ago

Before creating an issue, please take a look at the troubleshooting section.

System information

Describe the issue

Part of the script, winepath -w $RIOT_CLIENT, returns an empty string causing a sefault.

Steps to reproduce

leagueoflegends start

results in:

/usr/bin/leagueoflegends: line 371: 19657 Segmentation fault      (core dumped) wine "$(winepath -w "$RIOT_CLIENT")" --launch-product=league_of_legends --launch-patchline="$PATCHLINE"

When I change the script to set -eux, I can see that winepath -w $RIOT_CLIENT, returns an empty string causing a segfault. If I set $RIOT_CLIENT myself and run winepath -w $RIOT_CLIENT, I get the correct path. I don't know why this is not working within the script.

kyechou commented 1 year ago

That's interesting. But unfortunately I'm not able to reproduce the issue at my end. More information would be helpful.

Also, is it possible that it has something to do with zsh? I mean the shebang should have the script running with bash, but I'm not familiar with zsh enough to know if they have any effects on this.

kyechou commented 1 year ago

Hi @HBBrennan, I'm closing the issue for now due to inactivity and it not being reproducible. Please feel free to open the issue if the problem persists and please provide the output of leagueoflegends -v start (or install). Thanks!