search

kyeiti / UndergroundBiomesConstructs

Underground Biomes Constructs for Minecraft 1.12.2
Other
5 stars 3 forks source link

[1.12.2] [Request] Ore dictionary entries for UB ores #11

Closed Skaphegor closed 6 years ago

Skaphegor commented 6 years ago

I regonized that the UB iron ores are not registred as oreIron as well as the other ores. Maybe that could be added so that other mods can correctly idetify the ores.

kyeiti commented 6 years ago

I just double checked using the OreDictDumper.
They are registered (in the same dictionaries as the original ore)

Skaphegor commented 6 years ago

That is not shwon up to me. I will check this out tomorrow. The Digital Miner can't find iron and gold and the registration is not in JEI. Maybe another mod removes it.

Skaphegor commented 6 years ago

So I checked this out again. Some ores are oredicted and some are not, e.g. gold and iron. I used the dictionary of Mekanism but there was no registration in JEI also. 2018-05-23_01 32 04 2018-05-23_01 31 09 2018-05-23_01 31 17 2018-05-23_01 31 23 2018-05-23_01 31 58 2018-05-23_01 32 09 2018-05-23_01 32 07

kyeiti commented 6 years ago

Well that's odd. Can you double check for me, that the original ore has a dictionay entry? (Oh and I cannot really tell, which ores in your screenshots up there are which...)

For modded ores it might be a problem, if the mods adds the directory entry after UB copies the entries, but that reasoning cannot be applied to vanilla ores like gold and iron...

I guess I could add an "oreDictonaries"-entry to the ore-configuration so it can be used in case the coping doesn't work properly or some mod introduces an additional oreDictonary name.

With only JEI added gold and iron are certainly registered: 2018-05-27_14 10 04 2018-05-27_14 09 52

Skaphegor commented 6 years ago

Interesting. That another mod prevent the registration. I had a similar issue where bauxite can't be registered as oreAluminum if Thermal Foundation was present. I used several mods to add registration but it failed every time. I assume it is bad mod interaction. However I was told that "it is not TF fault". I will check the mods trying to find the bad one.

But I guess a config would be the better way.

Skaphegor commented 6 years ago

I tried to add entries with the new option. Only oreEnder could be registered. All other ores have no entries. I assume that another removes the registration. I thought of the Thermal series but it also happens if they are not present.

On the weekend I will try to find out which mod is causing this bad interaction and removing the entries.

Skaphegor commented 6 years ago

It was UniDict that removed the entries although it was set "ores" should not be unified. I close this for now.