kyeo76 / redux-nprogress

🔨 WIP: Redux Middleware, Reducer, Component & Actions for the most popular progress bar
27 stars 6 forks source link

Fix React.PropTypes deprecation warning #4

Closed eudaimos closed 7 years ago

eudaimos commented 7 years ago

@jaredt67 thanks for making a thoughtful and useful package.

This PR was originally made to fix #3

Includes the following changes

eudaimos commented 7 years ago

Thanks for merging @jaredt67 - will you be publishing a release to NPM?

kyeo76 commented 7 years ago

Thank you, @eudaimos! Yea, of course. So, the next version will be like 0.1.4 or 0.2.0?

eudaimos commented 7 years ago

@jaredt67 good question, I wouldn't consider a patch as it changes a dependency restriction although that change is a patch update - best to consult semver.org

I'm not sure if it's major or minor - but a few things 1) all pre-release versions (per semver) can make breaking changes so as you're below 1.0 you can pick either one - I think it's more than a patch 2) the package seems solid enough, I think you can bump to 1.0 (per doc updates #7 - I'll weigh in later today when I have some more time ) and make 2.0 the one with spinner support 3) please (per my request in #6 ) use Github releases to document your package versions - it'll not only help your users, but anyone trying to help support this package for you

eudaimos commented 7 years ago

@jaredt67 bump

kyeo76 commented 7 years ago

@eudaimos i bumped the version up to 1.0.0 and also created first release

viteksafronov commented 7 years ago

Still no package for npm and yarn :(