search

kyeotic / durandal-grid

A data-bindable grid widget with paging for Durandal
MIT License
11 stars 6 forks source link

Adding caption data-part #6

Closed navels closed 10 years ago

kyeotic commented 10 years ago

Can you also add a text binding for it. I imagine that will fill the general case.

navels commented 10 years ago

Not sure that will play well with formatting. For example, I want to do this:

<caption data-part="caption" class="text-left"><h3>My Table</h3></caption>

But I guess one can still do that, it'll just override the bound text. Maybe that's okay.

kyeotic commented 10 years ago

Node's with bindings and data-parts do not keep their bindings when being overridden. That's actually why overriding the grid body requires you to bind the foreach: rows yourself.

kyeotic commented 10 years ago

Btw, you said you were new to git so just in case you didn't know: if you just update the files in your branch the pull request will be updated automatically.

For future reference, you don't even need the separate branch on your fork. You can just make the changes in master, since your fork is its own independent repository. (This doesn't make any difference to me, it just might save you a couple seconds )

navels commented 10 years ago

Done, thanks for the tips!

kyeotic commented 10 years ago

Thank Navels, looks good =)