search

kyhjonathan / pe

0 stars 0 forks source link

Exception thrown when ctrl-c #3

Open kyhjonathan opened 7 months ago

kyhjonathan commented 7 months ago

An incorrect exception is thrown when user types in ctrl-c.

Steps to reproduce: User presses ctrl-c

image.png

nus-se-script commented 6 months ago

Team's Response

Hi. Thank you for pointing this out. Ctrl + C is used to forcefully terminate a running process. When you press Ctrl + C, the terminal sends an interrupt signal (SIGINT) to the process, causing it to stop immediately. Hence, we do acknowledge that an exception occurs if the user forcefully terminates the application using the Ctrl + C key binding.

However, handling this exception when a user forcefully exits the application was not of a high priority in v2.1 . This is for multiple reasons :

  1. When a user uses Ctrl + C, the intention here would to be stop using the application, hence, we do not necessarily believe that this flaw would cause any inconvenience to the user
  2. Despite this exception being shown, the application still works as intended. The user is still able to reopen the application without anything corrupted, and the most recent state of the application(before the user uses Ctrl + C) is still saved, allowing the user to use the application without any inconvenience at all.

Therefore, given that this flaw does not cause any issues within the application, it was not of a high priority in v2.1 and we have classified this as NotInScope

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]