kyhjonathan / pe

0 stars 0 forks source link

When finding expenses, program takes a value that is equals to the amount specified for "lessthan" #7

Open kyhjonathan opened 5 months ago

kyhjonathan commented 5 months ago

Steps:

  1. Have existing expense (in this case: description: Bruno Mars, amount: 167.00
  2. Search for existing expenses (i typed in :"find expenses d/bruno mars morethan/0 lessthan/167")
  3. still shows the expense, even though I want it to be LESS THAN $167

image.png

soc-pe-bot commented 5 months ago

Team's Response

Thank you for your suggestion. I do acknowledge that using the terms for my prefixes as morethan/ and lessthan/ may be a little counterintuitive. However, this is actually an intended output. Stated in the UG,

image.png

Where MAXAMOUNT and MINAMOUNT are the values 167 and 0 respectively w.r.t your input.

Hence, when searching for expenses less than 167, this would actually include expenses with the value 167 too as stated in the UG. Making the output in your picture an intended output.

I do acknowledge that this is a valid flaw, in particular a "cosmetic" flaw as users may mistakenly associate the lessthan prefix to not include their provided amount should they not read/have access to the UserGuide. However, as having a longer and clearer, prefix etc, lessthaneqto, lessthanequalsto would incur extra typing, the renaming of this prefix was not a huge priority in the implementation of v2.1.

Overall i agree with the VeryLow severity and classified this response as a NotInScope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]