kykc / MsiFanControl

Fan control utility for MSI laptops
MIT License
38 stars 8 forks source link

[Bug] Invalid class #10

Open KaKi87 opened 4 years ago

KaKi87 commented 4 years ago

Hello,

msifancontrol was working fine yesterday, but no longer working today.

No Windows nor software update as far as I know.

Output from PowerShell as admin :

PS C:\WINDOWS\system32> C:\msifancontrol\MsiFanControl.exe advanced /cpu:150,150,150,150,150,150 /gpu:150,150,150,150,150,150
Setting CPU fan values
Classe non valide
PS C:\WINDOWS\system32>

Classe non valide means Invalid class.

For some reason, re-running install solved the problem, however, it shouldn't have happened at the first place.

Any ideas why ?

Thanks

Subsidiary question : why not running install automatically instead of requiring the user to do it ?

kykc commented 4 years ago

Interesting. Install performs two simple operations: 1) copy MsiWmiAcpiMof.dll to SysWOW64 2) Add https://github.com/kykc/MsiFanControl/blob/master/MsiFanControl/MsiWmiAcpiMof.reg this to registry

I reckon something got corrupted along the way, file were deleted or registry entry was mangled.

Regarding second question: there were some complications. If I remember correctly install step is the only one which required Administrator privileges, maybe I've decided to make it explicit due to that. Another thing is that to automate this I'll needed to write some code to detect if install step was performed and if it's still effective (your case suggest that there are some pitfalls there).

KaKi87 commented 4 years ago

install step is the only one which required Administrator privileges

Actually, Windows shows UAC everytime I run msifancontrol, even for status or help commands.

to automate this I'll needed to write some code to detect if install step was performed and if it's still effective

Absolutely. That would make the install part unnecessary and prevent my problem for happening ever.

KaKi87 commented 4 years ago

Hello, any news on this ? (Just asking, although it's not a blocking issue) Thanks