I've tried to change it so we don't use openvpn_dns_servers at all, and the check for if we either add custom-servers vs the default DNS is based entirely on whether or not openvpn_custom_dns has entries in it.
This makes it more in-line with what the README says
Potentially breaking changes
If people have themselves been using the undocumented openvpn_dns_servers (and openvpn_custom_dns:true) it will no longer work
If people have been passing a bad list to openvpn_custom_dns without it actually writing them to config previously, it would now actually insert them which could potentially break
Hello,
I was using
openvpn_custom_dns
along withopenvpn_set_dns
astrue
and noticed it wasn't adding the servers to my openvpn config.Looking at the code it previously treated
openvpn_custom_dns
as if it was a Boolean, and instead usedopenvpn_dns_servers
to loop through the servers:It seemed to be suggesting that in our configs we set:
Which contradicted the docs which state:
I've tried to change it so we don't use
openvpn_dns_servers
at all, and the check for if we either add custom-servers vs the default DNS is based entirely on whether or notopenvpn_custom_dns
has entries in it. This makes it more in-line with what the README saysPotentially breaking changes
openvpn_dns_servers
(andopenvpn_custom_dns
:true
) it will no longer workopenvpn_custom_dns
without it actually writing them to config previously, it would now actually insert them which could potentially break