search

kyleady / inkpot-powerroll

GNU General Public License v3.0
2 stars 2 forks source link

Fixing Breaking changes with removal of word Beta. #4

Closed EndlesNights closed 8 months ago

EndlesNights commented 8 months ago

Sorry I accidently broke support for your module with the last patch, where I changed some name spaces around to remove the word Beta when I changed dnd4eBeta to dnd4e and DND4EBETA to DND4E.

Just a pull request that fixes the brake as of the Foundry DnD4e System update v0.4.44.

kyleady commented 8 months ago

Will this change make this module incompatible with older versions of 4e?

If so, is there a way to check the version of the system, and set the names with a variable?

EndlesNights commented 8 months ago

Yes this will brake support for older versions.

You can check the system version at game.system.version and we can use the helper function isNewerVersion( currentVersion, VersionToCheck) to check. I'll set up a new commit in a moment that checks the versions.

EndlesNights commented 8 months ago

Give that a quick try, and it should work.

kyleady commented 8 months ago

Checked it out, and it looks good. Thank you for fixing this!