search

kylebarron / arrow-wasm

Building block library for using Apache Arrow in Rust WebAssembly modules.
http://kylebarron.dev/arrow-wasm/
Apache License 2.0
18 stars 4 forks source link

Record batch access from table instances - probably typo #92

Closed H-Plus-Time closed 1 month ago

H-Plus-Time commented 2 months ago

It looks like both the record_batch and record_batches methods on Table are gated behind the 'recordBatch' feature (as opposed to 'record_batch') - that's a typo, right?

H-Plus-Time commented 2 months ago

I also had to prepend crate:: to the 4 references to RecordBatch, similar to the schema method.

kylebarron commented 1 month ago

Yeah, that's a typo. Are you able to make a quick pr fix?

H-Plus-Time commented 1 month ago

Yup, easy

kylebarron commented 1 month ago

Closed by #93