kylebarron / deck.gl-raster

deck.gl layers and WebGL modules for client-side satellite imagery analysis
https://kylebarron.dev/deck.gl-raster/
MIT License
85 stars 10 forks source link

Update module props without needing a texture reload #43

Closed kylebarron closed 4 years ago

kylebarron commented 4 years ago

Currently in landsat8.earth, I require a texture reload on every prop change:

    updateTriggers: {
      // Need to expand landsatBands array since comparison is shallow
      getTileData: [
        landsatMosaicId,
        naipMosaicId,
        landsatColormapName,
        landsatBandCombination,
        ...landsatBands,
      ],
    },

For these props (except for BandCombination), it's ok because the actual image texture inputs are changing. But now that I'm supporting more algorithms, things like a filter or sigmoidal contrast parameter changing should not need a texture reload.

kylebarron commented 4 years ago

I think this is fixed now since I do comparison of whether the images object has changed