Fixes for both report builds and PR comment workflow

kylebarron / parquet-wasm

Rust-based WebAssembly bindings to read and write Apache Parquet data

https://kylebarron.dev/parquet-wasm/

Apache License 2.0

482 stars 19 forks source link

Fixes for both report builds and PR comment workflow #495

Closed H-Plus-Time closed 2 months ago

H-Plus-Time commented 2 months ago

The report builds should resolve properly in this PR's actions, the PR comment stuff will only work after merging.

kylebarron commented 2 months ago

Is it expected that CI on this PR still fails?

H-Plus-Time commented 2 months ago

Alright, resolved for cases where the target branch has output asset manifests literally containing null.

~I think no-default-features isn't quite right for mimicking what used to be the arrow1 subset, I'll have a look at an older copy and see what is actually equivalent.~

Yep, both the slim and sync builds were previously overestimating the bundle size (by ~all compressions + async for slim, all compressions for sync). Should be much more accurate now.

kylebarron commented 2 months ago

Thanks!