search

kylebgorman / pynini

Read-only mirror of Pynini
http://pynini.opengrm.org
Apache License 2.0
120 stars 26 forks source link

Make concat an n-ary operation #10

Closed wrznr closed 5 years ago

wrznr commented 5 years ago

In contrast to union, concat is an operation which only accepts two operands. Maybe there is a technical reason for that? If not, it would be great to have concat accept more than two operands as well.

kylebgorman commented 5 years ago

Actually this was fixed in v. 2.0.1: concat now takes 2 or more arguments.

 In [4]: concat("foo", "bar", "baz")

 Out[4]: <vector Fst at 0x7aab285e7308>

Underlyingly though it (and composition, and union) are all implemented as binary algorithms with the obvious associativity.

K

On Sat, Jan 5, 2019 at 9:49 AM Kay-Michael Würzner notifications@github.com wrote:

In contrast to union, concat is an operation which only accepts two operands. Maybe there is a technical reason for that? If not, it would be great to have concat accept more than two operands as well.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kylebgorman/Pynini/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJuOS0QMQ8P3waR_CLqA3KgFGyy1Pmoks5vALtngaJpZM4ZxOvk .