search

kyleburton / bake

Pure bash, very lightweight scripting and build framework.
29 stars 8 forks source link

Fix bake init bug, update getting started #35

Closed ripclawffb closed 2 years ago

ripclawffb commented 2 years ago

When setting this up for the first time on my machine, I got an error because I didn't have an EDITOR environment variable set. This change fixes those errors.

$ bake init
/root/bin/bake: line 543: EDITOR: unbound variable

Also, when running bake get-started I got a similar error.

$ bake get-started
/root/Bakefile: line 7: EDITOR: unbound variable

I also updated the README.md because copying and pasting the commands from the examples didn't work. These updates should make it easier to copy and paste to run through the library tutorial.

Changed the default editor to vi since not all environments have vim installed.

kyleburton commented 2 years ago

This is awesome, ty! I only have one small request (above), and will ask if you've run shellcheck on the changes?

ripclawffb commented 2 years ago

This is awesome, ty! I only have one small request (above), and will ask if you've run shellcheck on the changes?

Thanks! :) I've made the shellcheck updates as requested.

kyleburton commented 2 years ago

Almost forgot, tho this PR is closed, would you mind adding yourself as a contributor? (in the readme) a contact email is optional, though I'd like for the folks who invested in this tool and project to have that investment noted for all to see :-D