search

kylec32 / dokuwiki_plantumlparser

A plugin to have a user's browser display a SVG PlantUML diagram generated at http://plantuml.com/
MIT License
8 stars 12 forks source link

Error when opening the page with the diagram over https #5

Closed yuretz closed 6 years ago

yuretz commented 6 years ago

It seems that this plugin always tries to load a diagram image over http, even when the page in question is loaded via https, and this results in the request being blocked by the browser and diagram not shown. On my machine I'm running Chrome 64 and it shows this: Mixed Content: The page at 'https://...' was loaded over HTTPS, but requested an insecure plugin resource 'http://www.plantuml.com/plantuml/svg/...'. This request has been blocked; the content must be served over HTTPS.

kylec32 commented 6 years ago

I really appreciate you reporting all of these issues.

This should now be fixed after an update.

Let me know if you continue to have issues.

yuretz commented 6 years ago

Nice, thank you, I'll try it tomorrow. Actually, if you leave out the protocol part when specifying the URL for your <object data=...> attribute and write it like //www.planttext.com/plantuml/svg/ instead, then the browser should be able to select the proper protocol automagically, so there'll be no need to hardcode https.

kylec32 commented 6 years ago

Oh cool. Yeah I actually moved it to rendering from a different now that supports https since my original one didn't support https

kylec32 commented 6 years ago

@yuretz Have you been able to give this a try? I believe it should work but wanted to double check before closing the feature.

yuretz commented 6 years ago

Oh, sorry I totally forgot about this issue, was pretty busy at work lately. Yes, I've tried it and it worked fine for me, thanks a lot.

kylec32 commented 6 years ago

No problem, thanks for the report.